Re: LIBTOOL_DEPS wrong when AC_CANONICAL_BUILD not called before initializing libtool

[Ralf Wildenhues]

Hello Jakub,

* Jakub Bogusz wrote on Sat, Mar 22, 2008 at 01:31:19PM CET:
> And for the second issue I reported in this thread (@LIBTOOL_DEPS@
> substitution):
> 
> #v+
> [configure.ac]
> AC_INIT([libtool-test], [0])
> LT_INIT
> AC_SUBST([LIBTOOL_DEPS])
> AC_CONFIG_FILES([Makefile])
> AC_OUTPUT
> 
> [Makefile.in]
> all: @LIBTOOL_DEPS@
> #v-
> 
> When AC_CANONICAL_BUILD is not called before LT_INIT (or
> AC_PROG_LIBTOOL, doesn't matter), @LIBTOOL_DEPS@ contains "/ltmain.sh"
> (instead of "./ltmain.sh"), so "make" will fail (unless "/ltmain.sh"
> really exists... but I suppose it won't happen anywhere).

Thanks for the example, and apologies for the huge delay.
I'm pushing this patch to fix it.

Cheers,
Ralf

        Ensure $ac_aux_dir is initialized for LIBTOOL_DEPS.

        * libltdl/m4/libtool.m4 (LT_INIT): Require
        AC_CONFIG_AUX_DIR_DEFAULT.
        * tests/old-m4-iface.at (AM_PROG_LIBTOOL): Amend test to
        expose this.
        Report, analysis, and test example by Jakub Bogusz.

diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 763a410..011b99c 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -66,6 +66,7 @@ esac
 # ------------------
 AC_DEFUN([LT_INIT],
 [AC_PREREQ([2.58])dnl We use AC_INCLUDES_DEFAULT
+AC_REQUIRE([AC_CONFIG_AUX_DIR_DEFAULT])dnl
 AC_BEFORE([$0], [LT_LANG])dnl
 AC_BEFORE([$0], [LT_OUTPUT])dnl
 AC_BEFORE([$0], [LTDL_INIT])dnl
diff --git a/tests/old-m4-iface.at b/tests/old-m4-iface.at
index 3365a2a..1e374d4 100644
--- a/tests/old-m4-iface.at
+++ b/tests/old-m4-iface.at
@@ -42,6 +42,7 @@ AT_SETUP([AM_PROG_LIBTOOL])
 AT_DATA([configure.in],
 [[AC_INIT(old.c)
 AM_PROG_LIBTOOL
+AC_SUBST([LIBTOOL_DEPS])
 AC_OUTPUT(Makefile)
 ]])
 
@@ -49,8 +50,9 @@ AT_DATA([Makefile.in],
 [[COMPILE = @CC@ @CPPFLAGS@ @CFLAGS@
 LINK      = @CC@ @CFLAGS@ @LDFLAGS@ -o $@
 SHELL     = @SHELL@
+LIBTOOL_DEPS = @LIBTOOL_DEPS@
 
-all: address@hidden@
+all: libtool address@hidden@
 
 address@hidden@: address@hidden@
        $(LINK) address@hidden@
@@ -60,6 +62,9 @@ address@hidden@: address@hidden@
 
 address@hidden@:
        $(COMPILE) -c $<
+
+libtool: $(LIBTOOL_DEPS)
+       $(SHELL) ./config.status --recheck
 ]])