[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: improve stlport4 check in libtool.m4
From: |
Ralf Wildenhues |
Subject: |
Re: improve stlport4 check in libtool.m4 |
Date: |
Thu, 14 Aug 2008 20:58:24 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hello Marc,
* Marc Glisse wrote on Wed, Aug 13, 2008 at 06:50:42PM CEST:
>
> libtool.m4 contains a test that may set solaris_use_stlport4 and disable
> the addition of "-library=Cstd,Crun" (which is a useful addition when
> creating shared objects with the default standard library).
Yes.
> I would just like to replace the test:
>
> *" -library=stlport4 "*)
>
> by:
>
> *" -library=stlport4 "* | *" -library=no%Cstd "*)
>
> (note that this code occurs in 2 places in the file, both of which could
> be changed)
One for Linux, one for Solaris.
> The point is that it is possible to use yet an other standard library
> than stlport4 (indeed the kde on solaris effort is using the apache
> stdcxx), in which case we also want to avoid "-library=Cstd". The
> compiler flag that disables Cstd is -library=no%Cstd (-library=stlport4
> is actually an alias for -library=no%Cstd,stlport4).
What about -library=Crun? Should it also be disabled upon encounter of
-library=no%Cstd?
> Note that the variable could be renamed since it is also used on linux,
> not only solaris, and with this patch would also be used with other
> alternate C++ standard libraries, but that does not really matter.
Oh, for maintainability this matters, though. The variable should be
renamed to lt_(cv_)suncxx_use_Cstd (with negated values), as far as I
understand. (The cv_ infix should be used if AC_CACHE_CHECK is used.)
Care to provide a patch? Bonus points for providing a testsuite
addition also (which is fine to be SKIPped non non-Solaris, non-Sun
compilers).
Thanks,
Ralf