Re: AC_LIBLTDL_CONVENIENCE

[Andreas Schwab]

Ralf Wildenhues <address@hidden> writes:

> Hello Andreas,
>
> * Andreas Schwab wrote on Wed, Apr 16, 2008 at 10:05:22AM CEST:
>> 
>> >  AU_DEFUN([AC_LIBLTDL_CONVENIENCE],
>> > -[_LT_CONFIG_LTDL_DIR([$1])
>> > +[_LT_CONFIG_LTDL_DIR(m4_ifval([$1], [$1], [libltdl]))])
>> >  _LTDL_CONVENIENCE])
>> 
>> Too many parens.
>
> Yep.  Also, can we have an example case for this one?

$ cat autoconf.ac
AC_INIT
AC_LIBLTDL_CONVENIENCE
AC_LIBTOOL_DLOPEN
AC_PROG_LIBTOOL
AC_CONFIG_FILES(Makefile)
AC_OUTPUT
$ cat Makefile.in
LIBLTDL = @LIBLTDL@
$ grep lt_ltdl_dir configure
lt_ltdl_dir=''
LIBLTDL='${top_build_prefix}'"${lt_ltdl_dir+$lt_ltdl_dir/}libltdlc.la"
LTDLINCL='-I${top_srcdir}'"${lt_ltdl_dir+/$lt_ltdl_dir}"
$ cat Makefile
LIBLTDL = ${top_build_prefix}/libltdlc.la

>
>> --- libltdl/m4/ltdl.m4       1 Apr 2008 18:23:20 -0000       1.46
>> +++ libltdl/m4/ltdl.m4       16 Apr 2008 08:04:41 -0000
>> @@ -79,7 +79,7 @@ _$0()
>>  # AC_LIBLTDL_CONVENIENCE accepted a directory argument in older libtools,
>>  # now we have LT_CONFIG_LTDL_DIR:
>>  AU_DEFUN([AC_LIBLTDL_CONVENIENCE],
>> -[_LT_CONFIG_LTDL_DIR([$1])
>> +[_LT_CONFIG_LTDL_DIR(m4_ifval([$1], [$1], [libltdl]))
>
> This looks like to few parens (outside of m4_ifval), although I haven't
> tested that and _LT_CONFIG_LTDL_DIR may require absence of quoting;
> also, m4_default should be able to simplify:
>   _LT_CONFIG_LTDL_DIR([m4_default([$1], [libltdl])])

I removed the outer parens because I had some expansion error, but I
can't reproduce that now.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."