Re: libtool 1.5.12: -pthread lost

[Peter O'Gorman]

Andreas Schwab wrote:
> Peter O'Gorman <address@hidden> writes:
> > Andreas Schwab wrote:
> > > Peter O'Gorman <address@hidden> writes:
> > > > Andreas Schwab wrote:
> > > > > libtool is throwing away the -pthread flag during linking.  It is now put
> > > > > in compiler_flags instead of deplibs, but the former seems to be ignored.
> > > > > Reverting this patch fixes the problem:
> > > > > 2005-01-16  Peter O'Gorman  <address@hidden>
> > > > >         * ltmain.in: Don't pass through compiler-like thread flags when
> > > > >         using $LD to do the linking. Use compiler_flags instead.
> > > > > Reported by address@hidden
> >
> > Gah! Okay, when linking executables the -pthread flag is dropped.
>
> Thanks, this is working fine.
>
> Andreas.
>
> P.S.: inline patches get completely ruined by format=flowed.

I applied (or at least am in the process of applying) this patch, and it's 
equivalent on HEAD and brnach-2-0.

Peter
--
Peter O'Gorman - http://www.pogma.com

Index: ChangeLog
2005-02-07  Peter O'Gorman  <address@hidden>

        * ltmain.in: Add -pthread like flags when linking executables too.
        Reported by Andreas Schwab <address@hidden>

Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.60
diff -u -3 -p -u -r1.334.2.60 ltmain.in
--- ltmain.in 5 Feb 2005 13:59:47 -0000 1.334.2.60
+++ ltmain.in 7 Feb 2005 14:02:09 -0000
@@ -1525,6 +1525,8 @@ EOF
 
      -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe)
        compiler_flags="$compiler_flags $arg"
+       compile_command="$compile_command $arg"
+       finalize_command="$finalize_command $arg"
        continue
        ;;