Re: libtoolize func_copy_all_from_path: broken

[Ralf Wildenhues]

* Akim Demaille wrote on Fri, Dec 17, 2004 at 12:04:22PM CET:
> 
> | func_copy_all_from_path ()
> | {
> |     if test "X$1" = X-r; then
> |       my_args=-r
> |       shift
> |     fi
> | 
> |     my_dirname="$1"
> |     my_srcpath="$2"
> |     my_destdir="$3"
> |     my_globexc="$4"
> | 
> |     save_IFS="$IFS"; IFS=:
> |     for myvdir in $my_srcpath; do
> |       IFS="$save_IFS"
> |       test "X$my_dirname" = X. || myvdir="$myvdir/$my_dirname"
> |       if test -d "$myvdir"; then
> |         eval func_copy_all_files $my_args "$myvdir" "$my_destdir" 
> "$my_globexc"
> 
> This eval is wrong.  Since $my_globexc contains |, the shell tries to
> use the glob patterns as commands of a pipe.

I fail to see why the eval would be necessary anyway.

> |         break
> |       fi
> |     done
> |     IFS="$save_IFS"
> | }

Thanks for reporting this.  Please consider reporting bugs which are in
development versions only (this one only applies to the HEAD branch) on
the libtool-patches mailing list.  Makes it much easier to track bugs in
released versions.

Applied the following to HEAD.

Thanks,
Ralf

2004-12-17  Akim Demaille <address@hidden>

        * libtoolize.m4sh (func_copy_all_from_path): Remove spurious eval.


Index: libtoolize.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libtoolize.m4sh,v
retrieving revision 1.4
diff -u -r1.4 libtoolize.m4sh
--- libtoolize.m4sh     29 Nov 2004 13:50:46 -0000      1.4
+++ libtoolize.m4sh     17 Dec 2004 12:58:26 -0000
@@ -237,7 +237,7 @@
       IFS="$save_IFS"
       test "X$my_dirname" = X. || myvdir="$myvdir/$my_dirname"
       if test -d "$myvdir"; then
-        eval func_copy_all_files $my_args "$myvdir" "$my_destdir" "$my_globexc"
+        func_copy_all_files $my_args "$myvdir" "$my_destdir" "$my_globexc"
         break
       fi
     done