Re: 1.5.10 CONFIG_SHELL must be reexported in tests/Makefile.am

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Fri, Dec 10, 2004 at 05:58:43PM CET:
> * Heinz Salzmann;Freiburg wrote on Fri, Dec 10, 2004 at 11:15:17AM CET:
> > 
> > here is a small patch to fullfil the requirement
> > 
> >    "# Be sure to reexport important environment variables." ;)
> > 
> > This is needed to get "make check" work on Solaris machines.
> 
> Thanks.  There's quite a bit more missing in branch-1-5, however, which
> we've added to HEAD already (F77, CXX, CXXFLAGS etc).  CONFIG_SHELL is
> missing for HEAD as well, and I've been having problems with this, too.

I think the best approximation is to set CONFIG_SHELL to the value we
computed for SHELL (the right thing would be to set CONFIG_SHELL only if
the user set CONFIG_SHELL, and not set it otherwise).  I'm not really
sure though, can you give the patch below a try?

Against branch-1-5.

Question for the other developers: Should I rather
AC_SUBST(CONFIG_SHELL) and reexport that (if not, $CONFIG_SHELL will be
empty when not user-set)?  Shouldn't Autoconf be doing this?

Regards,
Ralf

        * tests/Makefile.am: also re-export CPP, F77, FFLAGS, CXX,
        CXXFLAGS, CXXCPP, and the value of SHELL as CONFIG_SHELL.
        Reported by Heinz Salzmann <address@hidden>.

Index: tests/Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/Makefile.am,v
retrieving revision 1.32.2.2
diff -u -r1.32.2.2 Makefile.am
--- tests/Makefile.am   11 Dec 2004 14:40:25 -0000      1.32.2.2
+++ tests/Makefile.am   13 Dec 2004 08:42:55 -0000
@@ -77,9 +77,11 @@
 
 # Be sure to reexport important environment variables.
 TESTS_ENVIRONMENT = MAKE="$(MAKE)" CC="$(CC)" CFLAGS="$(CFLAGS)" \
-       CPPFLAGS="$(CPPFLAGS)" LD="$(LD)" LDFLAGS="$(LDFLAGS)" \
+       CPP="$(CPP)" CPPFLAGS="$(CPPFLAGS)" LD="$(LD)" LDFLAGS="$(LDFLAGS)" \
        LIBS="$(LIBS)" LN_S="$(LN_S)" NM="$(NM)" RANLIB="$(RANLIB)" \
-       OBJEXT="$(OBJEXT)" EXEEXT="$(EXEEXT)" FFLAGS="$(FFLAGS)" 
+       OBJEXT="$(OBJEXT)" EXEEXT="$(EXEEXT)" CONFIG_SHELL="$(SHELL)" \
+       CXX="$(CXX)" CXXFLAGS="$(CXXFLAGS)" CXXCPP="$(CXXCPP)" \
+       F77="$(F77)" FFLAGS="$(FFLAGS)"
 
 EXTRA_DIST = defs $(COMMON_TESTS) $(CXX_TESTS) $(F77_TESTS)