Re: osf5.1 + cc + -pthread

[Ralf Wildenhues]

* Peter O'Gorman wrote on Thu, Dec 02, 2004 at 04:17:12PM CET:
> Mark Andrews wrote:
> alphaev6-dec-osf5.1
> >
> >     I should be able to though some of the test machines are slow.
> >
> 
> Hi Mark,
> Thank you, just alphaev6-dec-osf5.1 with the -pthread flag will make me 
> happy enough.
> 
> This is against ltmain.in, but it should apply with fuzz to your ltmain.sh,

There's a bug in there:

> Index: ltmain.in
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
> retrieving revision 1.334.2.40
> diff -u -3 -p -u -r1.334.2.40 ltmain.in
> --- ltmain.in 29 Nov 2004 16:55:35 -0000      1.334.2.40
> +++ ltmain.in 2 Dec 2004 15:14:58 -0000
> @@ -1488,7 +1488,10 @@ EOF
>       ;;
>  
>       -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe)
> -     deplibs="$deplibs $arg"
> +     case "$archive_cmds" in
> +       *"\$LD"*) ;;
> +       *) deplibs="$deplibs $arg";;
> +     esac
>       continue
>       ;;
>  
> @@ -1976,7 +1979,10 @@ EOF
>           compile_deplibs="$deplib $compile_deplibs"
>           finalize_deplibs="$deplib $finalize_deplibs"
>         else
> -         deplibs="$deplib $deplibs"
> +         case "$archive_cmds" in
> +           *"\$LD"*) ;;
> +           *) deplibs="$deplibs $arg";;

This should be
   *) deplibs="$deplib $deplibs";;

instead.

> +         esac
>         fi
>         continue
>         ;;

Would $archive_expsyms_cmds also have to be checked for \$LD?  Other
than that, looks good to me, and would also help branch-2-0 and HEAD.
:-)

Regards,
Ralf