[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: icc/ecc full path and solaris link line fixes
From: |
Ralf Wildenhues |
Subject: |
Re: icc/ecc full path and solaris link line fixes |
Date: |
Mon, 15 Nov 2004 09:59:21 +0100 |
User-agent: |
Mutt/1.4.1i |
* Mats Rynge wrote on Thu, Nov 11, 2004 at 09:45:13PM CET:
> Attached is patches against branch-1-5 and HEAD fixing two problems:
>
> - a case statment comparing CC to icc*/ecc*. The comparasion fails if
> CC is set to the full path of the compiler (CC=icc works,
> CC=/opt/intel_cc_80/bin/icc would not work). Fix is to use
> cc_basename instead of CC.
This part looks good to me; Intel usually wants you to source the
.../bin/iccvars.{sh,csh},
which adjusts PATH and LD_LIBARY_PATH and such, but I can imagine
the advantage for multiple installed compilers, e.g.
> - added some missing ${wl} for solaris. The problem has been
> reported before:
> http://lists.gnu.org/archive/html/libtool/2004-07/msg00060.html
Looks good. Since I don't have access to Solaris: Is there a testcase
in the testsuite that is fixed by this? If not, we should maybe create
one. It'd also be great to know how the branch-2-0 testsuite fares on
Solaris, anyway.
> The HEAD patch is untested.
HEAD and branch-2-0 are not that far apart yet. Seems safe to me.
Regards,
Ralf