Re: potential AC_LIBTOOL_SYS_MAX_CMD_LEN bug

[Peter O'Gorman]

Willem Jan Palenstijn wrote:

> I started configure with "bash configure" and did not have
> $CONFIG_SHELL set. Note that in this case $0 equals "configure".

These should fix it. Applied to head and branch-1-5.

Thanks,
Peter
--
Peter O'Gorman - http://www.pogma.com

Index: ChangeLog
2004-08-04  Peter O'Gorman  <address@hidden>

        * m4/libtool.m4 (AC_LIBTOOL_SYS_MAX_CMD_LEN): Since CONFIG_SHELL may
        not actually be set, we should use SHELL here, also make darn sure
        that SHELL is set to something. Bug from Willem Jan Palenstijn
        <address@hidden>.

from  Jacob Meuser <address@hidden>
Index: m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/m4/libtool.m4,v
retrieving revision 1.86
diff -u -3 -p -u -r1.86 libtool.m4
--- m4/libtool.m4 2 Aug 2004 04:02:04 -0000 1.86
+++ m4/libtool.m4 4 Aug 2004 14:07:31 -0000
@@ -1135,10 +1135,11 @@ AC_CACHE_VAL([lt_cv_sys_max_cmd_len], [d
     for i in 1 2 3 4 5 6 7 8 ; do
       teststring=$teststring$teststring
     done
+    SHELL=${SHELL-${CONFIG_SHELL-/bin/sh}}
     # If test is not a shell built-in, we'll probably end up computing a
     # maximum length that is only half of the actual maximum length, but
     # we can't tell.
-    while (test "X"`$CONFIG_SHELL [$]0 --fallback-echo 
"X$teststring$teststring" 2>/dev/null` \
+    while (test "X"`$SHELL [$]0 --fallback-echo "X$teststring$teststring" 
2>/dev/null` \
               = "XX$teststring$teststring") >/dev/null 2>&1 &&
            test $i != 17 # 1/2 MB should be enough
     do

Index: ChangeLog
2004-08-04  Peter O'Gorman  <address@hidden>

        * libtool.m4 (AC_LIBTOOL_SYS_MAX_CMD_LEN): Since CONFIG_SHELL may
        not actually be set, we should use SHELL here, also make darn sure
        that SHELL is set to something. Bug from Willem Jan Palenstijn
        <address@hidden>.

from  Jacob Meuser <address@hidden>
Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.45
diff -u -3 -p -u -r1.314.2.45 libtool.m4
--- libtool.m4 2 Aug 2004 14:27:25 -0000 1.314.2.45
+++ libtool.m4 4 Aug 2004 12:40:35 -0000
@@ -695,7 +695,8 @@ AC_CACHE_VAL([lt_cv_sys_max_cmd_len], [d
     # If test is not a shell built-in, we'll probably end up computing a
     # maximum length that is only half of the actual maximum length, but
     # we can't tell.
-    while (test "X"`$CONFIG_SHELL [$]0 --fallback-echo "X$teststring" 
2>/dev/null` \
+    SHELL=${SHELL-${CONFIG_SHELL-/bin/sh}}
+    while (test "X"`$SHELL [$]0 --fallback-echo "X$teststring" 2>/dev/null` \
               = "XX$teststring") >/dev/null 2>&1 &&
            new_result=`expr "X$teststring" : ".*" 2>&1` &&
            lt_cv_sys_max_cmd_len=$new_result &&