Re: [BUG] AC_LIBTOOL_PROG_LD_HARDCODE_LIBPATH misuses shell test

[Peter O'Gorman]

Max Bowsher wrote:
> AC_LIBTOOL_PROG_LD_HARDCODE_LIBPATH contains the test:
>
> test "X$_LT_AC_TAGVAR(hardcode_automatic, $1)"="Xyes"
>
> Note that there is no space either side of the = .
>
> 'test STRING' is an alias for 'test -n STRING' causing this test to always
> return true, regardsless of the actual content of hardcode_automatic.
>
>
> Also, the line above that contains '_LT_AC_TAGVAR(runpath_var $1)'.
> Shouldn't there be a comma between the 2 arguments?

I just applied this attached patch to HEAD and branch-1-5.

Thanks,
Peter
--
Peter O'Gorman - http://www.pogma.com

? -p
? .cvsapplynum
? .gdb_history
? .patch_number
? 1-peter-extramodcmds.patch
? 1-peter-oldstriplib.patch
? 1-peter-tilde_in_path.patch
? 1-peter-tilde_in_path1.patch
? 10-peter-func_style.patch
? 10-peter-shrext_cmds.patch
? 100-peter-backup-changes.diff
? 11-peter-linkorder.patch
? 12-peter-darwin-xlc.patch
? 13-peter-test-correct-compiler.patch
? 14-peter-loader-dyld-fixes.patch
? 15-peter-fast-bsd-cmdlen.patch
? 2-peter-zsh_early_config_status.patch
? 3-peter-zshsucks.patch
? 4-peter-bloofyhell.patch
? 4-peter-darwin_libnames.patch
? 4-peter-zsh_ls_fix.patch
? 5-peter-zsh_cdpath_fix.patch
? 6-peter-quote_zsh_version.patch
? 7-peter-dontbuiltingench.patch
? 8-peter-noframeworks.patch
? 9-peter-infertagssucks.patch
? bloofy_crap_diff.patch
? ch.log
? check1.log
? check_gcc.log
? config-h.in
? configure.test
? d
? darwincrap.ltmain.diff
? diff.diff
? diff1.diff
? fat-darwin-diffs.diff
? fix-shrext.diff
? foo
? ld_hardcode_libpath.patch
? libtool-1.5a
? libtool-1.5a.tar.gz
? ltmain.my.in
? mdemo-dryrun.patch
? my.diff
? my1.diff
? myframeworkworks2.diff
? named-non-ranlibbed-ar
? real-12.diff
? stamp-h1
? config/depcomp
? libltdl/argz.h
? m4/ltversion.m4
? tests/ch.log
? tests/check1.log
? tests/foo12.cpp
? tests/mdemo/b.log
? tests/mdemo/build.log
? tests/mdemo/foo~1.c
? tests/tagdemo/.in
Index: ChangeLog
===================================================================
RCS file: /cvsroot/libtool/libtool/ChangeLog,v
retrieving revision 1.1494
diff -u -3 -p -u -r1.1494 ChangeLog
--- ChangeLog   22 Apr 2004 22:47:19 -0000      1.1494
+++ ChangeLog   5 May 2004 13:14:41 -0000
@@ -1,3 +1,9 @@
+2004-05-05  Peter O'Gorman  <address@hidden>
+
+       * m4/libtool.m4 (AC_LIBTOOL_PROG_LD_HARDCODE_LIBPATH): Insert space
+       around = for a test and a comma between runpath_var and $1. Bug
+       reported by Max Bowsher.
+
 2004-04-22  Gary V. Vaughan  <address@hidden>
 
        * libltdl/argz.h: Moved from here...
Index: m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/m4/libtool.m4,v
retrieving revision 1.69
diff -u -3 -p -u -r1.69 libtool.m4
--- m4/libtool.m4       19 Apr 2004 15:04:17 -0000      1.69
+++ m4/libtool.m4       5 May 2004 13:14:44 -0000
@@ -1477,8 +1477,8 @@ AC_DEFUN([AC_LIBTOOL_PROG_LD_HARDCODE_LI
 [AC_MSG_CHECKING([how to hardcode library paths into programs])
 _LT_AC_TAGVAR(hardcode_action, $1)=
 if test -n "$_LT_AC_TAGVAR(hardcode_libdir_flag_spec, $1)" ||
-   test -n "$_LT_AC_TAGVAR(runpath_var $1)" ||
-   test "X$_LT_AC_TAGVAR(hardcode_automatic, $1)"="Xyes" ; then
+   test -n "$_LT_AC_TAGVAR(runpath_var, $1)" ||
+   test "X$_LT_AC_TAGVAR(hardcode_automatic, $1)" = "Xyes" ; then
 
   # We can hardcode non-existant directories.
   if test "$_LT_AC_TAGVAR(hardcode_direct, $1)" != no &&