Re: libtool-1.5.4 patch

[Gary V . Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 5 Apr 2004, at 03:06, Peter O'Gorman wrote:
> Peter Breitenlohner wrote:
> > 2. the rules for local-install-files badly fail (at least when 
> > $(srcdir)!=.).
> > With automake 1.8.3 $(DISTFILES) contains several entries which 
> > already have
> > an explicit $(srcdir) attached. The code I have inserted is a 
> > simplified
> > version of the automake-generated code for the `distdir' target.
> > Wouldn't it be much better (less fragile) to have all that done via
> > automake, e.g. with
> >         ltldir = $(datadir)/libtool/libltdl
> >         ltl_DATA = COPYING.LIB Makefile.am Makefile.in README .... ltmain.sh
> >         ltl_SCRIPTS = config.guess config.sub configure .... missing
> > or similar.
>
> Rather than applying your patch as is, I must also ask the guru's ... 
> why aren't we using automake to install these files?

This was added to close a security hole in Automake's then installation 
rules.

] fgrep -l local-install-files ChangeLog*
ChangeLog
ChangeLog.1999
] sed -e '/local-install-files/,/^$/ {p;};d' ChangeLog.1999
        * libltdl/Makefile.am (local-install-files):  New rule to 
install
        libltdl without creating links or mode 777 directories.
        * instutil/*: deleted.

] sed -e '/local-install-files/,/^$/ {p;};d' ChangeLog
        (local-install-files): Removed.  This hack is not required
        anymore, the automake generated install rules are much more
        advanced than this.
        * Makefile.am (install-data-hook, uninstall-local): Removed.
        Libltdl files for libtoolize are installed by their own Makefile
        now.

Mea culpe.  I fixed HEAD but not branch-1-5.  Please merge from HEAD 
into branch-1-5.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (Darwin)

iD8DBQFAcQ/3FRMICSmD1gYRAtfqAJ9YfYjecCUmEh9spMy39jI7ZPvUxQCcCgWj
ijT4dY16qVljsfqM73puihs=
=UckR
-----END PGP SIGNATURE-----