bug-librejs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix: typo in a dependency name in the libreJS development notes.


From: Ayushman Tripathi
Subject: Re: fix: typo in a dependency name in the libreJS development notes.
Date: Mon, 29 Jan 2024 22:51:40 +0530
User-agent: Mozilla Thunderbird

Yuchen, I've attached the updated patch, and for now, I've updated acorn to

acorn@"<=8.7.1" as specified by you.
 
But in my last email, I've described that acorn@8.11.3 also works well.

On 27-01-2024 09:28, Yuchen Pei wrote:
Hi Ayushman,
On Fri 2024-01-26 23:04:05 +0530, Ayushman Tripathi wrote:

Thanks for the patch.

 [... 34 lines elided]

      
RCS file: /web/librejs/librejs/manual/html_node/LibreJS-Development-Notes.html,v
retrieving revision 1.2
diff -u -r1.2 LibreJS-Development-Notes.html
--- manual/html_node/LibreJS-Development-Notes.html	17 Sep 2023 08:15:25 -0000	1.2
+++ manual/html_node/LibreJS-Development-Notes.html	25 Jan 2024 12:19:04 -0000
The html manual is generated using gnulib gendocs.sh from the texinfo
source, which is docs/librejs.texi in the librejs code repo:

https://www.gnu.org/prep/maintain/html_node/Invoking-gendocs_002esh.html
https://git.savannah.gnu.org/cgit/librejs.git/tree/docs/librejs.texi

Please send a patch that updates the .texi file instead.

@@ -63,7 +63,7 @@
 <p>LibreJS 7.21 depends on a number of Node.js-based libraries that
 can be installed using the <code class="code">npm</code> utility:
 </p>
-<pre class="verbatim">  $ npm install acorn-loose jassha browserify
+<pre class="verbatim">  $ npm install acorn-loose jssha browserify
acorn now has a version constraint, see the README file in the librejs.
Please include that in your patch.

[... 4 lines elided]
Best,
Yuchen

--
Dr Yuchen Pei | https://ypei.org | Timezone: UTC+11
PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
https://ypei.org/assets/ypei-pubkey.txt

Attachment: 0001-fix-typo-in-the-dependency-name.patch
Description: Text document

Attachment: OpenPGP_0x9DAB5E772EDA5326.asc
Description: OpenPGP public key


reply via email to

[Prev in Thread] Current Thread [Next in Thread]