[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ifconfig: Fix ASAN 'dynamic-stack-buffer-overflow' in formatting.
|
From: |
Simon Josefsson |
|
Subject: |
Re: ifconfig: Fix ASAN 'dynamic-stack-buffer-overflow' in formatting. |
|
Date: |
Tue, 07 May 2024 09:25:45 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Collin Funk <collin.funk1@gmail.com> writes:
> On 5/6/24 6:03 PM, Collin Funk wrote:
>> So I am confident it is a bug. I've applied the attached patch which
>> seems to fix the issue. This is based on a quick glance of the code so
>> I would appreciate others looking it over. Thanks!
Thank you! I think we should figure out how to run ASAN builds via
CI/CD to catch regression of bugs like this.
> Oops, I forgot to run 'make indent', sorry...
> I'll just leave it for now in case a NEWS entry should also be added
> for this change. I'm not too sure how that works.
Yes please indent code and write a NEWS entry about fixing some ASAN
alarms.
/Simon
signature.asc
Description: PGP signature