Re: cfg.mk: Add checks for 'caddr_t'.

[Collin Funk]

On 5/6/24 5:26 AM, Simon Josefsson wrote:
> Looks good to me, feel free to push.

Done, with some slight changes to the fist patch now that some checks
are in Gnulib.

> I do mostly agree, however there is another concern: frivolious changes
> like this makes it harder to align code with BSD implementations for
> auditing and security backports.  I've sporadically coordinated some
> security fixes with tnftp which seems to be the maintained BSD ftp
> implementation.  I've noticed they have a bunch of fixes that went into
> that code over the years that we don't have.  Of course, they likely
> won't add any of our improvements, but I don't think there is a lot of
> arguments why we shouldn't continue to import good patches from BSD ftp
> to GNU ftp.  I have a mental todo to attempt to do a BSD-to-GNU diff on
> some of these tools, and backport all reasonable improvements they have.

Ah, good point, thanks for mentioning. Do you happen to know off the
top of your head what programs are still maintained by the BSDs? If
not I can do some research and make sure to be more careful making
changes there.

The BSD-to-GNU diff doesn't sound very fun based on the different
coding styles alone.

> For this particular example, they replaced a (caddr_t*) cast to (char*)
> which I think is just wrong (the type is sockaddr_in and not char*).  So
> your patch is better.

I'm assuming you mean (caddr_t) to (char *) here?

I think caddr_t is just a pointer type so it would be fine. I don't
think the standard grantees all pointer types are the same size, but
in practice they should be.

Collin