Oddity with make check: syslogd.sh PASSes w/o VERBOSE, but FAILs with VERBOSE=1 (reason: too many successful tests)

[Erik Auerswald]

Hi,

I've been looking into the code some more and tried out the test suite
("make check").  One of the tests, syslogd.sh, FAILed for me when I also
set VERBOSE=1 (or VERBOSE=yes).  The problem reported by the test script
is that 36 of 33 tests passed, i.e., the count of successful tests is
higher than the total test count, but only if VERBOSE is set.

A quick glance at the test script did not suffice for me to understand
and fix the problem.

This is with GNU inetutils 2.2.  The test/syslogd.sh code did not change
in git since then.

    $ make TESTS=syslogd.sh check | grep -E '^(X?PASS|SKIP|X?FAIL|ERROR)'
    PASS: syslogd.sh

    $ make TESTS=syslogd.sh VERBOSE=1 check | grep -E 
'^(X?PASS|SKIP|X?FAIL|ERROR)'
    FAIL: syslogd.sh
    FAIL: syslogd.sh
    FAIL syslogd.sh (exit status: 1)
    make[5]: *** [test-suite.log] Error 1
    make[4]: *** [check-TESTS] Error 2
    make[3]: *** [check-am] Error 2
    make[2]: *** [check] Error 2
    make[1]: *** [check-recursive] Error 1
    make: *** [check] Error 2

    $ make TESTS=syslogd.sh VERBOSE=yes check | grep -E 
'^(X?PASS|SKIP|X?FAIL|ERROR)'
    FAIL: syslogd.sh
    FAIL: syslogd.sh
    FAIL syslogd.sh (exit status: 1)
    make[5]: *** [test-suite.log] Error 1
    make[4]: *** [check-TESTS] Error 2
    make[3]: *** [check-am] Error 2
    make[2]: *** [check] Error 2
    make[1]: *** [check-recursive] Error 1
    make: *** [check] Error 2

The same problem happens when running all tests, i.e., without
"TESTS=syslogd.sh".

Thanks,
Erik
-- 
Hofstadter's Law: It always takes longer than you expect, even when
                  you take into account Hofstadter's Law.