[bug-inetutils] --pattern doesn't seem to work in inetutils ping

[Colum Paget]

Hi all,

I could be doing this wrong, but from what I can see the --pattern
option to ping doesn't work in inetutils 1.9. If I do:

ping -p ff 127.0.0.1

Then

/usr/sbin/tcpdump -n -e -i lo -X -s 4000 icmp

shows

10:23:49.273026 00:00:00:00:00:00 > 00:00:00:00:00:00, ethertype IPv4
(0x0800), length 98: 127.0.0.1 > 127.0.0.1: ICMP echo request, id
32351, seq 2048, length 64
        0x0000:  4500 0054 d643 4000 4001 6663 7f00 0001  address@hidden@.fc....
        0x0010:  7f00 0001 0800 1a6b 7e5f 0800 b5b6 8e54  .......k~_.....T
        0x0020:  0f2a 0400 0000 0000 0000 0000 0000 0000  .*..............
        0x0030:  0000 0000 0000 0000 0000 0000 0000 0000  ................
        0x0040:  0000 0000 0000 0000 0000 0000 0000 0000  ................
        0x0050:  0000 0000


The packet appears to be padded with 0 bytes, rather than 0xFF bytes
as requested.


I also had a minor problem when compiling. I got this error:

make[4]: Entering directory '/home/metacosm89/inetutils-1.9/lib'
  CC     argp-ba.o
  CC     argp-eexst.o
In file included from /usr/include/sys/types.h:219:0,
                 from ./sys/types.h:28,
                 from ./stdio.h:58,
                 from argp.h:22,
                 from argp-eexst.c:25:
./stdio.h:1030:1: error: 'gets' undeclared here (not in a function)
 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
 ^
Makefile:1728: recipe for target 'argp-eexst.o' failed
make[4]: *** [argp-eexst.o] Error 1
make[4]: Leaving directory '/home/metacosm89/inetutils-1.9/lib'


And solved it by commenting out the line

_GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");

at lineno 1030 in lib/stdio.h


regards,

Colum