bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] Overriding SUID installs.


From: Mats Erik Andersson
Subject: [bug-inetutils] Overriding SUID installs.
Date: Thu, 2 Feb 2012 00:53:40 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Dear all,

would the change below make sense, allowing vendors and builders
to override a strong SUID assignment?

Regards,
  Mats


diff --git a/ping/Makefile.am b/ping/Makefile.am
index 5da4782..7410344 100644
--- a/ping/Makefile.am
+++ b/ping/Makefile.am
@@ -30,7 +30,7 @@ ping_SOURCES = ping.c ping_common.c ping_echo.c 
ping_address.c \
   ping_router.c ping_timestamp.c ping_common.h  ping_impl.h ping.h libping.c
 ping6_SOURCES = ping6.c ping_common.c ping_common.h ping6.h
 
-SUIDMODE = -o root -m 4775
+SUIDMODE ?= -o root -m 4775
 
 install-ping-hook:
        address@hidden x in $(bin_PROGRAMS); do \
diff --git a/src/Makefile.am b/src/Makefile.am
index a85fff4..476c2d3 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -100,7 +100,7 @@ INCLUDES = $(iu_INCLUDES) -I$(top_srcdir)/libicmp
 
 AM_CPPFLAGS = $(PATHDEF_BSHELL) $(PATHDEF_CONSOLE) $(PATHDEF_CP) 
$(PATHDEF_DEFPATH) $(PATHDEF_DEV) $(PATHDEF_INETDCONF) $(PATHDEF_INETDDIR) 
$(PATHDEF_INETDPID) $(PATHDEF_KLOG) $(PATHDEF_LOG) $(PATHDEF_LOGCONF) 
$(PATHDEF_LOGIN) $(PATHDEF_LOGPID) $(PATHDEF_NOLOGIN) $(PATHDEF_RLOGIN) 
$(PATHDEF_RSH) $(PATHDEF_TTY) $(PATHDEF_UTMP) $(PATHDEF_UUCICO)
 
-SUIDMODE = -o root -m 4775
+SUIDMODE ?= -o root -m 4775
 
 install-exec-hook: @traceroute_INSTALL_HOOK@ @rsh_INSTALL_HOOK@ 
@rlogin_INSTALL_HOOK@ @rcp_INSTALL_HOOK@
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]