[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] Macros __unix__ and unix.
From: |
Alfred M. Szmidt |
Subject: |
Re: [bug-inetutils] Macros __unix__ and unix. |
Date: |
Sun, 08 Jan 2012 14:03:02 -0500 |
> a good solution, or should we let "configure.ac" trigger
> the insertion of a macro "unix" based on "__unix__", should
> the former be missing?
I don't care strongly, but support doing either.
However, your question begs the bigger question: do we really need these
#ifdef's at all? I looked at a few files, and most of the usage looked
like hacky workarounds. It is some work to rewrite the code though...
Yeah, telnet/telnetd contain a lot of cruft... If we can remove these
#ifdefs, or replace them by proper configure.ac checks, then this is
super.
For ftpd/ftpcmd.y I would leave the __unix__/unix ifdefs, they are
mostly correct. If those macros are defined, then it is a "UNIX"
environment (very much similar to what we do in ifconfig).
For telnetd/telnet we use those macros in a bit different way, and
they should be killed of. I'd recommend running the unifdef on
telnet/telnetd where __unix__/unix are defined, and clean it up.
Ditto for the TN3270, CRAY, ultrix, and what not.
I can do that.