bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] On logwtmp and ftpd, rlogind, and uucpd.


From: Mats Erik Andersson
Subject: [bug-inetutils] On logwtmp and ftpd, rlogind, and uucpd.
Date: Tue, 22 Nov 2011 11:58:28 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Dear all,

we have presently two implementations of logwtmp():

   libinetutils/logwtmpko.c

   ftpd/logwtmp.c

both building a "keep open" variant. Then there is
a backing code

   libinetutils/logwtmp.c

which is written to build either "keep open" or "standard".
The latter possibility is never used (see "logwtmpko.c"!),
and this fact is the sole cause that "uucpd" cannot be built
on Solaris, since there logwtmp(3) is missing and "libinetutils.a"
is only offering logwtmp_keep_open(). On BSD systems or GLibc
systems this passes, since the supply logwtmp(3) natively.

For the next iteration this code duplication and missuse
should be reviewed. Observe also that "ftpd/logwtmp.c"
implements logwtmp(), but ftpd itself is using logwtmp_keep_open()
from "libinetutils.a"! The only other users of logwtmp() present
in our code base are rlogind and uucpd, and of course the code
internal to "libinetutils.a".

Best regards,
  Mats



reply via email to

[Prev in Thread] Current Thread [Next in Thread]