Re: [bug-inetutils] [Platform-testers] inetutils pre-release

[Simon Josefsson]

Mats Erik Andersson <address@hidden> writes:

> måndag den 14 november 2011 klockan 11:21 skrev Simon Josefsson detta:
>> Bruno Haible <address@hidden> writes:
>> > In other words, you need to add $(LIBREADLINE) to the value of LDADD
>> > in telnet/Makefile.am.
>> >
>> > Likewise in telnetd/Makefile.am.
>> 
>> Thanks for analyzing, I agree and pushed this tiny change in your name.
>> 
>> > Quite odd situation, but IMO the readline macro should not set
>> > HAVE_LIBREADLINE
>> > if the include files are missing, or the code in ftp/cmds.c should
>> > be testing
>> >   HAVE_LIBREADLINE && HAVE_READLINE_READLINE_H
>> > instead of just
>> >   HAVE_LIBREADLINE
>> 
>> Yes.  However, wouldn't an even better solution be to use
>> AC_LIB_LINKFLAGS here instead of the current check for readline?  That
>> should be more reliable.
>
> Related to this is the fact that <term.h> must be prepended by <curses.h>
> in all standards. Also <stropts.h> is needed with HAVE_STREAMSPTY.
>
> The commit 0a83fb1 attends to these matters and it achieves correct
> building of telnet and telnetd for
>
>   GNU/Linux, GNU/kFreeBSD, GNU/OpenSolaris, OpenBSD, and OpenIndiana.

I noticed that there is a gnulib module called 'readline' that InetUtils
is already including (!) so I have removed all cruft in configure.ac
regarding readline and fixed some usage for ftp.  The one part I feel
less confident about is the libhistory stuff -- but I reckon that if
something more is needed, we should handle it in a modern way (i.e.,
either AC_LIB_LINKFLAGS or gnulib).

Please test this whether it builds now.  Eventually we should make
another snapshot, but there are more things that needs to be attended to
from the first platform-testers response, so let's hold off that until
we have fixed more issues.

/Simon