Re: [bug-inetutils] Remarks on OpenSolaris/NexentaCore.

[Mats Erik Andersson]

Dear all,

this message from Simon never got transmittet by our list manager
at Savannah, so I use the direct copy to compose an answer.

söndag den 19 juni 2011 klockan 11:32 skrev Simon Josefsson detta:
> Mats Erik Andersson <address@hidden> writes:
> 
> > <syslog.h>
> >
> >    Missing LOG_PERROR
> 
> Can you tell if there is any similar flag?  The man page for 'openlog'
> may help.  It is an glibc'ism, maybe something for gnulib.

In fact, LOG_PERROR is missing in POSIX.1-2001, so OpenSolaris
chooses not to include it. Inetutils uses it only in 'src/logger.c'.
The strange fact is that one instance of LOG_PERROR is protected
by '#iddef', while three other are not, so this error cause is
easily mended. Adding the conditionals will make the use independent
of any additions to GNUlib, a good thing.

> 
> >    Missing CODE
> >    Missing facilitynames
> >    Missing prioritynames
> 
> Where are these used?  Can't find them in POSIX nor glibc manual.
> Possibly they should not be used.

   src/logger.c
   src/syslogd.c

> 
> > <syslog-int.h>
> >
> >    Does not exist. Its content is brought in
> >    by <syslog.h> itself. In reality, the desired
> >    declarations are located in <sys/syslog.h>.
> 
> I don't think InetUtils should include this file.

It is brought in as soon as SYSLOG_NAMES is not able
to detect the presence some of 'LOG_FAC', 'prioritynames',
and 'CODE'. All these are missing in OpenSolaris. The
macro LOG_FAC can be copied verbatim from glibc, but
the other two need workarounds.

> 
> > Linking networking code
> >
> >    Needs '-lsocket'
> 
> Gnulib should already take care of that.

The problem is that our templates '*/Makefile.am' ignore
to mention '$(LIBSOCKET)' in the default linking rules.
In addition, much networking code needs linking against
'-lnsl', so a macro 'LIBNSL' should be introduced and put
to good use in all build file templates.

Another observation: In 'libls/fts.c' there is a reference
to 'rindex(3)'. This needs '<strings.h>', but only '<string.h>'
gets included. I believe there is a misprint in the source file,
but not in this remark!

Regards,
  Mats