bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] [PATCH] syslogd: Dereferencing NULL.


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] [PATCH] syslogd: Dereferencing NULL.
Date: Tue, 14 Jun 2011 15:27:17 -0400

   > I have discovered a NULL pointer leading to segmentation fault.
   > The rescue has been verified on GNU/Linux and OpenBSD.
   > 
   > Alongside comes a first test script to check the abilites of the
   > syslogd server. The script was really intended for the upcoming
   > IPv6 changes, but proved instrumental in locating also the
   > present defect.
   > 
   > I am asking for acceptance as usual.

   Alfred, a month has passed without any acceptance or reject on this
   matter. I will not proceed on IPv6 for 'syslogd' until the present
   bug has been mended. We owe it to our users to display the
   incorrect code. Already next patch from me will replace the code
   involved here, as well as much of its vicinity.

Sorry!  Thank you for reminding me, and again sorry for letting balls
drop like this specially since your patches are always so good.  

As far as I'm concerned, you have free reign over the tree like the
rest of the maintainers and some other folks--whoever those are.  So
if us maintainers are non-responsive, feel free to go ahead and commit
if you feel it is good and don't get feedback on things.  I promise to
be more on things from now one in either case.

Ok to commit; if you fix the typo for the file-name for src/syslogd.c :-)

2011-06-14  Mats Erik Andersson <address@hidden>
   
        * src/syslogd.d (fprintlog): Sanity check on `f->f_prevhost'
        to avoid deferencing NULL.
        (cfline): A permanently failed DNS lookup must produce F_UNUSED.
        * tests/syslogd.sh: New file.
        * tests/Makefile.am (dist_check_SCRIPTS) [ENABLE_logger &&
        ENABLE_syslogd]: Add `syslogd.sh'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]