bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] inetd: Environment and IPv6.


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] inetd: Environment and IPv6.
Date: Tue, 09 Nov 2010 18:26:09 -0500

   I would like to submit a patch that implements for Inetd the
   exporting of environment variables also with IPv6.

Mats, you're just amazing. :-)

   2010-11-08  Mats Erik Andersson <address@hidden>
   
        * src/inetd.c (prepenv): New prototype: `prepenv(int, struct
        sockaddr *, socklen_t)'.

        (prepenv): Change type of IP to `char []' of fixed length.
        New integer variable RET.  Make type of SA_SERVER depend on
        macro IPV6: `struct sockaddr_storage' or `struct sockaddr_in'.

Could you document in a comment why IP is 4 times larger than
INET6_ADDRSTRLEN?

        (prepenv): Eliminate uses of `inet_ntoa', `gethostbyaddr' by
        new calls to `getnameinfo', with and without demand on numeric
        results.  Debugging output on three select environment
        variables.

        (main): Make type of SA_CLIENT depend on macro IPV6: `struct
        sockaddr_storage' or `struct sockaddr_in'.  Adaption to new
        prototype for `prepenv'.
   
Someone shoould write a book on the art of writting ChangeLog entries;
in this case I would have just written `handle enviromental variables
when handling IPv6 connections'.  But this is just as grand!  Ok to
commit, push if tested and such.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]