Re: [bug-inetutils] Tracking of build failures.

[Alfred M. Szmidt]

        Should we eliminate the build of `talk' and `talk' for any
        system where neither `struct osockaddr' nor `<osockaddr.h>'
        exist? Similar to the exclusion of `ping6' whenever "IPV6 !=
        1".

Excluding ping6 is for different reasons, I can't see anything that
actually uses osockaddr.  What do you think about the following patch?

   Is there any information available for OpenSolaris, AIX, HP-UX,
   NetBSD, MirBSD, Dragonfly, etcetera?

Not as far as I know with any recent version of inetutils.



2010-11-06  Alfred M. Szmidt  <address@hidden>

        * talk/ctl.c [HAVE_OSOCKADDR_H]: Don't include <osockaddr.h>.
        * talkd/intalkd.h [HAVE_OSOCKADDR_H]: Likewise.
        * talk/look_up.c [HAVE_OSOCKADDR_H]: Likewise.
        * talk/invite.c [HAVE_OSOCKADDR_H]: Likewise.
        * talk/get_names.c [HAVE_OSOCKADDR_H]: Likewise.
        * talk/get_addrs.c [HAVE_OSOCKADDR_H]: Likewise.
        * talk/ctl_transact.c [HAVE_OSOCKADDR_H]: Likewise.
        * configure.ac: Removed check for osockaddr.

diff --git a/configure.ac b/configure.ac
index c1ac270..824e090 100644
--- a/configure.ac
+++ b/configure.ac
@@ -493,14 +493,6 @@ AC_CHECK_TYPE(socklen_t, ,
               [IU_FLUSHLEFT([#include <sys/types.h>
                             #include <sys/socket.h>])])
 
-dnl We may need our own definition for struct osockaddr (equivalent to the
-dnl old 4.3BSD struct sockaddr, and used in grotty bsd talk protocol)
-AC_CHECK_TYPE(struct osockaddr, ,
-              [AC_DEFINE([HAVE_OSOCKADDR_H], 1,
-                         [Define to one if you have <osockaddr.h>.])],
-             [IU_FLUSHLEFT([#include <sys/types.h>
-                             #include <sys/socket.h> ])])
-
 AC_CHECK_TYPES(struct if_nameindex, , ,
   [IU_FLUSHLEFT([#include <sys/types.h>
                  #include <sys/socket.h>
diff --git a/talk/ctl.c b/talk/ctl.c
index 6628ea4..3508595 100644
--- a/talk/ctl.c
+++ b/talk/ctl.c
@@ -57,9 +57,6 @@
 
 #include <sys/types.h>
 #include <sys/socket.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <netinet/in.h>
 #include "talk.h"
diff --git a/talk/ctl_transact.c b/talk/ctl_transact.c
index bd5abfb..2f33134 100644
--- a/talk/ctl_transact.c
+++ b/talk/ctl_transact.c
@@ -55,9 +55,6 @@
 #include <time.h>
 #include <netinet/in.h>
 #include <sys/select.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <errno.h>
 #include "talk_ctl.h"
diff --git a/talk/get_addrs.c b/talk/get_addrs.c
index 695f368..488d660 100644
--- a/talk/get_addrs.c
+++ b/talk/get_addrs.c
@@ -55,9 +55,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <netdb.h>
 #include <stdio.h>
diff --git a/talk/get_names.c b/talk/get_names.c
index 366d329..ba8ef03 100644
--- a/talk/get_names.c
+++ b/talk/get_names.c
@@ -55,9 +55,6 @@
 #include <sys/types.h>
 #include <sys/param.h>
 #include <sys/socket.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <netinet/in.h>
 #include <protocols/talkd.h>
 #include <pwd.h>
diff --git a/talk/invite.c b/talk/invite.c
index bb6af33..ef69130 100644
--- a/talk/invite.c
+++ b/talk/invite.c
@@ -57,9 +57,6 @@
 #include <time.h>
 #include <signal.h>
 #include <netinet/in.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <errno.h>
 #include <unistd.h>
diff --git a/talk/look_up.c b/talk/look_up.c
index d6ff8e4..7871ba9 100644
--- a/talk/look_up.c
+++ b/talk/look_up.c
@@ -54,9 +54,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <unistd.h>
 #include <errno.h>
diff --git a/talkd/intalkd.h b/talkd/intalkd.h
index d9efd24..0f7d76d 100644
--- a/talkd/intalkd.h
+++ b/talkd/intalkd.h
@@ -22,9 +22,6 @@
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
-#ifdef HAVE_OSOCKADDR_H
-# include <osockaddr.h>
-#endif
 #include <protocols/talkd.h>
 #include <netdb.h>
 #include <syslog.h>