Re: [bug-inetutils] Re: [PATCH] Inetd and test scripts

[Alfred M. Szmidt]

   >    > @@ -22,13 +22,15 @@
   >    >  TFTP="${TFTP:-../src/tftp$EXEEXT}"
   >    >  TFTPD="${TFTPD:-$PWD/../src/tftpd$EXEEXT}"
   >    >  INETD="${INETD:-../src/inetd$EXEEXT}"
   >    > -IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT}"
   >    > +IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT --format=unix}"
   >    >  
   >    > -PORT=7777
   >    > +AF=${AF:-inet}
   >    > +PROTO=${PROTO:-udp}
   >    > +PORT=${PORT:-7777}
   >
   >    Not sure these were absolutely necessary...
   >
   > I see no reason why they are unnecessary, can you explain why you
   > think otherwise?

   It’s over-generalization.  At least it belongs in a different patch.

I don't see the harm in it since it is such a small change, though
maybe you are right... I am as guilty of commiting unrelated things in
the same commit.

   >    > +# Check that the port is still available
   >    > +netstat -na | grep -q "^$PROTO .*$PORT "
   >    > +if test $? -eq 0; then
   >    > +    echo "Desired port $PORT/$PROTO is already in use."
   >    > +    exit 1
   >    > +fi
   >
   >    This breaks because ‘netstat’ may not be in $PATH; in particular, it
   >    breaks the Hydra builder: <http://hydra.nixos.org/build/727555>.
   >
   > Why is netstat not in PATH? 

   Why would it be?  :-)

   Only dependencies explicitly specify appear in $PATH in Nix(OS)
   builders.

Then netstat should be mentioned as a dependency for IU, or if Nix can
detect it through other means (like your suggestion via AC_CHECK_PROG
in configure.ac).

   > inetd is spawned into the background, and you can get a small race
   > condition so the sleep does no harm.

   Right, and I admit I had blissfully overlooked it.  :-)

   However, it’s fragile, and calls for better synchronization.

Absolutley agreed, don't get me wrong.  The current test suite is
lacking but the work you, and Mats are doing is immensly helpful!  We
are not close to a release, so we have time to fix all these issues,
and I suspect that they will crop up on Solaris, or other platforms,
this is a work in progress and both of you are doing great work (while
we--and i'm refering to Jeff, Alain, Sergey and myself--are being lazy
and taking credit for it =)