[bug-inetutils] Re: [PATCH] Inetd and test scripts

[Ludovic Courtès]

Hello,

address@hidden (Alfred M. Szmidt) writes:

>    > --- a/tests/tftp.sh
>    > +++ b/tests/tftp.sh
>    > @@ -22,13 +22,15 @@
>    >  TFTP="${TFTP:-../src/tftp$EXEEXT}"
>    >  TFTPD="${TFTPD:-$PWD/../src/tftpd$EXEEXT}"
>    >  INETD="${INETD:-../src/inetd$EXEEXT}"
>    > -IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT}"
>    > +IFCONFIG="${IFCONFIG:-../ifconfig/ifconfig$EXEEXT --format=unix}"
>    >  
>    > -PORT=7777
>    > +AF=${AF:-inet}
>    > +PROTO=${PROTO:-udp}
>    > +PORT=${PORT:-7777}
>
>    Not sure these were absolutely necessary...
>
> I see no reason why they are unnecessary, can you explain why you
> think otherwise?

It’s over-generalization.  At least it belongs in a different patch.

>    > +# Check that the port is still available
>    > +netstat -na | grep -q "^$PROTO .*$PORT "
>    > +if test $? -eq 0; then
>    > +    echo "Desired port $PORT/$PROTO is already in use."
>    > +    exit 1
>    > +fi
>
>    This breaks because ‘netstat’ may not be in $PATH; in particular, it
>    breaks the Hydra builder: <http://hydra.nixos.org/build/727555>.
>
> Why is netstat not in PATH? 

Why would it be?  :-)

Only dependencies explicitly specify appear in $PATH in Nix(OS)
builders.

> inetd is spawned into the background, and you can get a small race
> condition so the sleep does no harm.

Right, and I admit I had blissfully overlooked it.  :-)

However, it’s fragile, and calls for better synchronization.

Thanks,
Ludo’.