[bug-inetutils] Re: configure.ac: Missing header inclusion in IPv6 test.

[Simon Josefsson]

Mats Erik Andersson <address@hidden> writes:

> lördag den 18 september 2010 klockan 19:21 skrev Mats Erik Andersson detta:
>> Hello,
>> 
>> with the help of Bruno Haible, a bug has been located in
>> 
>>    inetutils/configure.ac
>> 
>> The original thread started in
>> 
>>    http://lists.gnu.org/archive/html/bug-gnulib/1010-09/msg00328.html
>> 
>> but the message below expresses the conclusion.
>
> Clearly a lack of initiative!
>
> The proposed change can not be avoided on OpenBSD in order to see the
> variable IPV6 defined after configuration.

Thanks for posting a patch, applied and pushed.

Without your copyright papers in order, it becomes harder and harder to
push even trivial patches like this -- what is the status of your
copyright assignment?

/Simon

> From 8591f62c03209707edfed7dfeab9f97b7367f748 Mon Sep 17 00:00:00 2001
> From: Mats Erik Andersson <address@hidden>
> Date: Tue, 28 Sep 2010 23:20:12 +0200
> Subject: [PATCH] configure.ac: Improve test of `struct sockaddr_in6`.
>
> ---
>  ChangeLog    |    5 +++++
>  configure.ac |    3 ++-
>  2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 1ff6282..6f6632b 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2010-09-28  Mats Erik Andersson <address@hidden>
> +
> +     * configure.ac: Unconditionally include <sys/types.h> when
> +     checking for `struct sockaddr_in6'. Needed for OpenBSD.
> +
>  2010-09-15  Mats Erik Andersson <address@hidden>
>  
>       * telnetd/telnetd.c (login_invocation, argp_options):
> diff --git a/configure.ac b/configure.ac
> index 5c6c3a5..ec0e7df 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -328,7 +328,8 @@ if test ! "X$ipv6" = "Xno" && test "X$working_ipv6" = 
> "Xyes"; then
>  fi
>  
>  if test ! "X$ipv6" = "Xno" && test "X$working_ipv6" = "Xyes"; then
> -  AC_CHECK_TYPE(struct sockaddr_in6, , working_ipv6=no, [#include 
> <netinet/in.h>])
> +  AC_CHECK_TYPE(struct sockaddr_in6, , working_ipv6=no, [#include 
> <sys/types.h>
> +#include <netinet/in.h>])
>  fi
>  
>  if test ! "X$ipv6" = "Xno" && test "X$working_ipv6" = "Xyes"; then