[bug-inetutils] Re: [PATCH] Implement IPv6 capability for the TFTP server.

[Mats Erik Andersson]

måndag den 27 september 2010 klockan 13:23 skrev Simon Josefsson detta:
> Mats Erik Andersson <address@hidden> writes:
> 
> > Let me for free provide a strong reason to reject also the new patch,
> > a patch with which I myself am content:
> >
> >    There is no trace of conditioning the changes on either of
> >
> >        IPV6
> >        HAVE_IPV6
> >        HAVE_DECL_GETADDRINFO
> >        HAVE_DECL_FREEGETADDRINFO
> >        HAVE_DECL_GAI_STRERROR
> >        HAVE_DECL_GETNAMEINFO
> >        HAVE_STRUCT_SOCKADDR_STORAGE
> >        
> >    so my suggestion fails to compile on any machine where IPv6
> >    is not supported!

> What kind of code do you have that condition on IPV6/HAVE_IPV6?  It may
> be possible to rewrite it in a protocol independent way.

None whatsoever! The only compiling dependency for the TFTP server is on

     struct sockaddr_storage
     AF_UNSPEC
     AF_INET6
     getnameinfo(3)

My other suggested patching of the TFTP client presently adds

     NI_MAXSERV
     struct addrinfo
     getaddrinfo(3)
     gai_strerror(3)
     freeaddrinfo(3)
     strrchr(3)

All these are fulfilled by any decent OS as far as I understand.


Mats E A