[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] ping socket_type issue
From: |
Alfred M. Szmidt |
Subject: |
Re: [bug-inetutils] ping socket_type issue |
Date: |
Tue, 20 Oct 2009 10:18:09 -0400 |
2009/10/20 Alfred M. Szmidt wrote:
> � I was looking at ping/ping.c and noticed what might be an issue
> � with the socket_type variable. �Both the -r and -d option set
> � socket_type directly rather than perform an |= like is done with
> � the option variable. �The result would seem to be that the -r and
> � -d option are mutually exclusive when they don't need to be.
>
> Would you like to send a patch to fix this issue?
In case Ben is okay with it, I had already sent a patch for this issue
just beneath his mail, in this very thread. Alfred may you review it ?
It also contains fix for one wrong assignment for option 'r' in
parse_opt in ping6.c.
Sorry, I missed it.
Please use your full name, full option names (--debug vs. -r), two
periods after a sentence, and something a bit more descriptive as the
change line. The ChangeLog shouldn't be a regexp of the actual code
changes, but describe them.
For example,
* ping/ping.c (parse_opt): Handle `--debug' and `--ignore-routing'
simultaneously.
* ping/ping6.c (parse_opt): Likewise. Set `socket_type' to SO_DONTROUTE.
Other than that, if it is tested, feel free to push.