[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] [PATCH] ping/ping6 --deadline option

From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] [PATCH] ping/ping6 --deadline option
Date: Mon, 05 Oct 2009 04:15:17 -0400

   May you suggest something better then TIMEOUT_UNSPECIFIED ? I cannot
   think of anything more suitable then this.

I don't know why you need that macro, just define the variables to -1.
Please call the variable timeout, not ping_timeout.
ping_check_timeout should be renamed to something sensible, like
ping_timeout_p.  Also make sure that you use proper indentation.

You changed the sequence of how gettimeofday is called in ping_run
without explaining it.

   +2009-10-04  Rakesh Pandit <address@hidden>
   +    * ping/ping_common.c (ping_check_timeout): New function.
   +    * ping/ping_common.h (ping_data): Added ping_start_time member.
   +    * ping/libping.c (ping_init): Set ping_data member ping_start_time
   +    with gettimeofday.
   +    * ping/ping6.c (ping_init): Likewise.
   +    * ping/ping.c: New option: --timoue, to set timeout before ping
   +    exits.
   +    (parse_opt): Added new entry for 'w' and validity check for
   +    timeout.
   +    (ping_init): Calling ping_check_timeout after each packet sent.
   +    * ping/ping6.c (parse_opt): Likewise.

You did not modify ping6.c:parse_opt to call ping_timeout_p, so the
above ChangeLog is incorrect.  Please look at previous ChangeLog
entries for examples of how to write them.  You also have few spelling
mistakes, and you only use one space after end of sentence, when it
should be two.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]