[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] bug in bitfield macros

From: Christopher Zimmermann
Subject: [bug-inetutils] bug in bitfield macros
Date: Mon, 17 Aug 2009 12:40:44 +0200


I just discovered a small bug in ping. The macros for accessing the 
bitfields in ping.h and the way they are called results in only one bit 
stored per byte. I assume the desired behavior was to store 8 bits per 
byte. So I hope this patch fixes this small issue. It also removes a 
small piece of orphan code.

Currently I'm working on timestamps generated by hardware or software 
using the SO_TIMESTAMPING socket option introduced with linux 2.6.30.

Are you interested in patches for ping to use this feature? How do you 
think I should implement it?
My plan is to add a ping_tstamp[N] of timespecs to the ping_data 
structure in which I will store the transmit timestamps addressed by 
their sequence number modulo N.


Christopher Zimmermann

Attachment: ping.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]