[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] [PATCH 3/7] argp'fied argument parsing & tiny fixes

From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] [PATCH 3/7] argp'fied argument parsing & tiny fixes
Date: Fri, 26 Sep 2008 19:14:12 -0400

   > _FOO tends to be reserved for the compiler, and lower level parts.  I
   > generally use something like:
   > | struct cmd_args
   > | {
   > |   char **argv[8];
   > |   char **argptr;
   > | };
   > | typedef struct cmd_args cmd_args_t;

   Ah, Actually this is my favorite style too.  Since I spotted some
   of the current code to use _FOO style, for sake of following
   conventions I did it that way.

I do not have any opinions on which to use; changing all occurences to
one format won't do much. 

  Anyways, Fixed.

Thank you.

   PS, telnet code looks to me as a real classic, mid 80's or
   something like that. is it really that old ?

Yes. Telnet is a very old program, and ours is based on the one in
BSD4.4 Lite2.

   Patch is updated.

Thank you, it looks good now.  As soon as the legal work is done, I'll
commit your changes (or I'll just give you commit access and you can
do it yourself).

Happy hacking, now I'm going to bed...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]