[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] Re: ping6 seg fault patch - 1

From: Rakesh Pandit
Subject: Re: [bug-inetutils] Re: ping6 seg fault patch - 1
Date: Wed, 27 Aug 2008 11:39:22 +0530

2008/8/27 Alfred M. Szmidt <address@hidden>:
>   +2008-08-27  Rakesh Pandit <address@hidden>
>   +
>   +    * ping/ping6.c (main, parse_opt): Fixed segmentation fault
>   +    in ping6.
> The ChangeLog entry should describe the code changes, not the result
> of the change.  See the other ChangeLog's for examples.


> There is a ping_set_count, pint_set_interval and ping_set_sockopt that
> you should use instead of accessing the ping structure directly.

These functions are in ping.h and not in ping6. These lines will change once
I move those functions to ping_common later on. If I fix this now
patch will grow again.

I would rather like to go in steps as you folks suggested last week.

My point was to fix this Segmentation faut before moving common code
so as to keep
testing each options. Once i move them these lines will also change.

Later on this start up code will be same for both (once most of common
code is removed).

Comments ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]