[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] [PATCH 1/7] argp'fied argument parsing & tiny fixes
From: |
Alfred M. Szmidt |
Subject: |
Re: [bug-inetutils] [PATCH 1/7] argp'fied argument parsing & tiny fixes |
Date: |
Sat, 23 Aug 2008 05:01:36 -0400 |
Tool name: ftpd
ftpd/ftpd.c:
* Removed getopt () interface
* Added argp_* interface
* Removed usage ()
Note that we use GNU ChangLog entries, please check the GNU Coding
Standards, and the ChangeLog file in inetutils.
+const char AUTH_ARG_DESC[] = "Use AUTH for authentication, it can be:\n"
+"\tdefault (passwd authentication)\n"
+#ifdef WITH_PAM
+"\tpam (using pam 'ftp' module)\n"
+#endif
+#ifdef WITH_KERBEROS
+"\tkerberos\n"
+#endif
+#ifdef WITH_KERBEROS5
+"\tkderberos5\n"
+#endif
+#ifdef WITH_OPIE
+"\topie"
+#endif
+;
I find this immensly ugly. For one, AUTH_ARG_DESC is not a macro, so
it should not be upper-case. Secondly, I am guessing that --help will
look completely messed up. Something simpler would be more useful,
just a comma seperated list of the options available. Or simply not
listing them at all, they should be documented in the manual.