Re: [bug-inetutils] PATH_WTMP in logwtmp.c

[Jeff Bailey]

I'd think that the Right Thing here is that all of these should be in
config.h.  I can't see a good reason to override these with make for
testing.

I can try to take a look at this over the holidays.  Assuming I can
figure out my cvs access.  I haven't looked at inetutils in a long
time.

Unless Alfred is bored... =)

2007/12/21, Michael Geng <address@hidden>:
> I'm running a normal PC (Intel 686) and Debian Linux (etch).
>
> config.h contains
>
> /* Define to 1 if you have the `updwtmp' function. */
> #define HAVE_UPDWTMP 1
>
> /* Define to 1 if you have the `updwtmpx' function. */
> #define HAVE_UPDWTMPX 1
>
> and libinetutils/Makefile contains
>
> CONFIG_HEADER = $(top_builddir)/config.h
> ...
> AM_CPPFLAGS = $(PATHDEF_WTMPX) $(PATHDEF_TTY_PFX) $(PATHDEF_DEVNULL) 
> $(PATHDEF_HEQUIV)
> ...
> PATHDEF_WTMP = -DPATH_WTMP=\"/var/log/wtmp\"
> PATHDEF_WTMPX = -DPATH_WTMPX=\"$(localstatedir)/log/wtmpx\"
>
> Thanks for your reply but I'm afraid I need more help. I still don't know
> if I'm doing something wrong, something's broken in the cvs archive or
> something's wrong with my environment.
>
> Michael
>
> On Fri, Dec 21, 2007 at 10:50:34AM -0800, Jeff Bailey wrote:
> > What platform are you running on, btw?
> >
> > Check to see if that define is in config.h, then check to make sure
> > config.h is getting pulled in.
> >
> > 2007/12/21, Michael Geng <address@hidden>:
> > > Hi,
> > >
> > > I downloaded the inetutils sources from cvs. Unfortunately it fails to 
> > > build
> > > with the following message:
> > >
> > > make[2]: Entering directory 
> > > `/home/linux/tmp/inetutils-cvs-12-19-2007/libinetutils'
> > > gcc -DHAVE_CONFIG_H -I. -I.. -I../headers -I../lib -I../lib 
> > > -DPATH_WTMPX=\"/usr/local/var/log/wtmpx\" -DPATH_TTY_PFX=\"/dev/\" 
> > > -DPATH_DEVNULL=\"/dev/null\" -DPATH_HEQUIV=\"/etc/hosts.equiv\"    -g -O2 
> > > -MT logwtmpko.o -MD -MP -MF .deps/logwtmpko.Tpo -c -o logwtmpko.o 
> > > logwtmpko.c
> > > In file included from logwtmpko.c:2:
> > > logwtmp.c: In function '_logwtmp':
> > > logwtmp.c:70: error: 'PATH_WTMP' undeclared (first use in this function)
> > > logwtmp.c:70: error: (Each undeclared identifier is reported only once
> > > logwtmp.c:70: error: for each function it appears in.)
> > >
> > > What am I doing wrong? config.log shows
> > >
> > > #define PATH_WTMP "/var/log/wtmp"
> > > #define PATH_WTMPX "$(localstatedir)/log/wtmpx"
> > >
> > > Shouldn't logwtmp.c be compiled with -DPATH_WTMP set instead of 
> > > -DPATH_WTMPX
> > > or PATH_WTMP in logwtmp.c be replaced with PATH_WTMPX?
> > >
> > > Michael
>


-- 
Jeff Bailey - http://www.raspberryginger.com/jbailey/