bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-inetutils] ftpd and noisy 530 errors


From: Alfred M. Szmidt
Subject: [bug-inetutils] ftpd and noisy 530 errors
Date: Tue, 17 Oct 2006 01:15:08 +0200 (CEST)

This supposedly "prevents ftpd to display noisy 530 error message.", I
can't test it though I see no direct harm in this patch, so unless
someone objects I'll commit it in a day or two.

The patch was a unsubmitted one by the Gentoo people, many thanks to
them for keeping notes about what the patch fixes!

2006-10-17  Alfred M. Szmidt  <address@hidden>

        * ftpd/auth.c (auth_user): Free PCRED->message if sgetcred()
        returns non-zero.

Index: ftpd/auth.c
===================================================================
RCS file: /cvsroot/inetutils/inetutils/ftpd/auth.c,v
retrieving revision 1.3
diff -u -r1.3 auth.c
--- ftpd/auth.c 12 Oct 2006 09:57:27 -0000      1.3
+++ ftpd/auth.c 16 Oct 2006 23:09:12 -0000
@@ -116,13 +116,17 @@
              }
          }
        else
-         return 1;
+         {
+           free (pcred->message);
+           pcred->message = NULL;
+           return 1;
+         }
        pcred->dochroot = checkuser(PATH_FTPCHROOT, pcred->name);
        snprintf (pcred->message, len,
                  "Password required for %s.", pcred->name);
        return 0;
       }
-    } /* swithch (auth_type) */
+    } 
   return -1;
 }
 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]