Re: Fwd: [bug-inetutils] [PATCH] fix whitespace parsing in syslogd

[Julian Gilbey]

On Tue, Sep 02, 2003 at 10:32:17PM +0200, Marcus Brinkmann wrote:
> On Tue, Sep 02, 2003 at 01:10:22PM +0100, Julian Gilbey wrote:
> > Applied; works correctly.
> 
> Thanks for testing it.

8-)

> Well, that was another report :)
> 
> > --- syslogd/syslogd.c.orig  2003-08-23 22:34:40.000000000 +0100
> > +++ syslogd/syslogd.c       2003-08-24 00:39:27.000000000 +0100
> > @@ -1679,7 +1679,7 @@
> 
> Please use the -p option to patch so it shows function names.

OK!

> Also, please consider to write a ChangeLog entry according to our standards
> when submitting a patch.

OK, shall endeavour to do so in future.

> > +     cline = cbuf + offset + len - 1;  /* reset cline for new cbuf */
> 
> And last but not least, follow the GNU coding standard ;)
> Comments should be full sentences, with correct ortography (ie, uppercase,
> witha final period).  In this case, the comment does not explain the code,
> but repeats it, which is unnecessary.  So I removed it.

Makes sense!

> [...]
> Right, the code was bogus.  Thanks for spotting this and submitting a fix.

Pleasure.

   Julian

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

        Julian Gilbey, website: http://www.polya.uklinux.net/
   Debian GNU/Linux Developer, see: http://people.debian.org/~jdg/
     Visit http://www.thehungersite.com/ to help feed the hungry