Re: Small patch for libicmp/icmp_cksum.c

[Paul Jarc]

address@hidden wrote:
> -    {
> -      *(u_char *)&answer = *(u_char*)wp;
> -      sum += answer;
> -    }
> +    sum += (unsigned short)*(u_char *)w;

* This won't have the same effect as the original code on a big-endian
  system.
* For consistency, it would be better to use the u_short typedef
  instead of unsigned short.
* You mistyped the variable name as w instead of wp, which shows that
  you didn't even try to compile this code, let alone test it.


paul