bug in 1.4.1

[Chris Ulherr]

Hey,

I found another bug in the rshd for 1.4.1.

If you do a rsh <host> <command>

to a server running the 1.4.1 rshd, you get the following error message:

Host address mismatch for <hostname>

In the syslog:

Sep  7 04:56:44 makati-sysa rshd[20633]: Host addr 10.28.65.141 not
listed for host makati-sysa
Sep  7 04:56:44 makati-sysa rshd[20633]: address@hidden as geo:
permission denied. cmd='a'




The problem is in rshd.c line 464:

if (check_all || local_domain (hp->h_name))

hp is a struct hostent *

So it it set in line 450:
hp = gethostbyaddr(....)

However in line 464, local_domain is called.
This in turn calls localhost().
However, localhost *sets the external variable*
that hp points to.

After this function call, hp is now pointing to what was
returned by localhost().

This causes the aforementioned errors.



--Chris