Re: Patch for inetutils 1.3.2

[Marcus Brinkmann]

Hi Davin,

On Sat, Feb 16, 2002 at 11:11:46AM +1100, Davin McCall wrote:
> After a small amount of investigating I have found the problem: syslogd
> reads from the kernel message device (/proc/kmsg on my machine) with a
> "read" call, and expects to read a line at a time. This will not necessarily
> work.

You are right, this is indeed a problem.  Your fix was going in the right
direction, but not the whole way:  It can happen that we read multiple
lines, and any other combination.  I have commited some code that should
cover all cases, and gave it some rudimentary testing.

It would be nice if you could test the current CVS version.  1.3.2 is very
old, and your patch is against the old version of the code (the new version
had the same problem, though :)  Please make sure you have the following
change in syslogd/ChangeLog:

2002-03-05  Marcus Brinkmann  <address@hidden>

        * syslogd.c (main): New variables KLINE and KLINE_LEN, to store
        partial lines from the kernel log device.  Collect partial lines
        until we either have a maximum partial line or a full line.  Log
        that, and all following lines collected so far, and in the case of
        the maximum partial line skip the remainder of the current line.
        Reported by Davin McCall <address@hidden>.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org address@hidden
Marcus Brinkmann              GNU    http://www.gnu.org    address@hidden
address@hidden
http://www.marcus-brinkmann.de