[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: coding style
From: |
Sergey Poznyakoff |
Subject: |
Re: coding style |
Date: |
Sat, 11 Aug 2001 09:02:51 +0300 (EET DST) |
Hi
> Sergey, your code follows mostly the GNU coding style, with a couple
> of mistakes here and there (like, space between function name and opening
> parentheses, or binary operators at the end of a wrapped line, rather
Yes, I've noticed this. These are rudiments of my K&R indentation :^)
> than the beginning of the next line). Any objection if I go through the
> code and correct these?
Of course, no. Please, do. If you wish, I can do it myself, to save you the
trouble.
> Also, for consistency, may I ask you that you keep an empty line between
> the ChangeLog entry opening line and the first changelog entry?
OK, I will.
> Also, in ping/ping_echo.c, MAXHOSTNAMELEN is used in ipaddr2str.
> The Hurd does not define this symbol, so compilation breaks.
> This needs to be fixed to deal with arbitrary long host names.
> Can you do this?
Sure. I'll commit necessary changes in a couple of days.
Regards,
Sergey
- coding style, Marcus Brinkmann, 2001/08/09
- Re: coding style,
Sergey Poznyakoff <=