[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
coding style
From: |
Marcus Brinkmann |
Subject: |
coding style |
Date: |
Thu, 9 Aug 2001 18:16:42 +0200 |
User-agent: |
Mutt/1.2i |
Hi,
Sergey, your code follows mostly the GNU coding style, with a couple
of mistakes here and there (like, space between function name and opening
parentheses, or binary operators at the end of a wrapped line, rather
than the beginning of the next line). Any objection if I go through the
code and correct these?
Also, for consistency, may I ask you that you keep an empty line between
the ChangeLog entry opening line and the first changelog entry?
emacs20 does this automatically if you add the items with C-x 4 a.
Also, in ping/ping_echo.c, MAXHOSTNAMELEN is used in ipaddr2str.
The Hurd does not define this symbol, so compilation breaks.
This needs to be fixed to deal with arbitrary long host names.
Can you do this?
Thanks,
Marcus
- coding style,
Marcus Brinkmann <=