Re: ifconfig and some minor fixes.

[Sergey Poznyakoff]

Hi, Marcus!

> My questions:
> 
>   * ifconfig/flags.c: #include <sys/socket.h>
>   * ifconfig/options.c: include <sys/socket.h>.
> MB: Why are they needed in flags.c, options.c? <net/if.h> should suffice.
On Solaris `struct sockaddr' is defined in sys/socket.h, if the header
is not included before <net/if.h> compilation bails out on any member
of `struct  sockaddr' type it encounters. It is surely not needed on
`normal' systems, but it doesn't hurt anyway, so I have #included it
unconditionally.

> MB: I'd prefer to do
> #define ifr_netmask ifr_addr
> on such systems.  Is Solaris such a system?
Yes, unfortunately it is :( Actually it is the most brain-damaged
system I ever worked with, and that is why I am trying to make 
inetutils work on it: if it compiles there it will compile anywhere :^).


>   * ifconfig/system.c, ifconfig/system.h: added ifdef __sun__ clause
> MB: What's the story between __sun__ and __solaris__?  I changed __solaris__
> to __sun__ now, as I don't remember why I put __solaris__ there.  Do older
> systems define __sun__, too?
All systems I had access to define __sun__, but I suppose 
#ifdef __solaris__ won't hurt either.

>   * ifconfig/system/solaris.c: Added system_configure().
> MB: Has Solaris IFTXQLEN? What is the FIXME supposed to mean?
Well, I am not sure about a correct way to set txqlen. There surely
must be a way to do this, but I still haven't found it. That's why
I have marked the spot with FIXME.

Regards,
Sergey