bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

some clean up, and what needs to be cleaned up


From: Marcus Brinkmann
Subject: some clean up, and what needs to be cleaned up
Date: Mon, 30 Oct 2000 02:24:50 +0100
User-agent: Mutt/1.1.4i

Hi,

I am commiting now some small fixes. Basically, I fixed one security bug
(use of mktemp), and the output of ftpd (--help, --version). Some other fies
that remove compiler warnings are also included. A pointer was dereferenced
wrongly.

Compiling with -Wall revealed some problems. Beside the warnings for the
code which is not audited and GNU'ified yet, there is the problem with
missing prototypes: We don't have a header for libinetutils. We need to
think that over. There are a couple of other places which look suspicious,
but this might be a transient problem. I will try to take care of that so
that we have a -Wall clean inetutils at release time (or almost).

What about all those sccsid tags? They are useful for our reference, so we
know which code base this is. But I don't think that including the strings
in the binary is useful, as the user can't get useful information from it.
After all, we did a lot of modifications, and so the information in those
tags is not correct for the current code. I suggest to replace those "#ifndef
lint" checks with "#if 0". This also makes gcc happy.

Now the next step is to review more code, and convert it to gnu standards.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org address@hidden
Marcus Brinkmann              GNU    http://www.gnu.org    address@hidden
address@hidden
http://www.marcus-brinkmann.de



reply via email to

[Prev in Thread] Current Thread [Next in Thread]