Re: [PATCH v2 glibc] Add pthread_getname_np and pthread_setname_np for Hurd

[Carlos O'Donell]

On 7/15/24 7:45 AM, Andreas K. Huettel wrote:
>>> diff --git a/sysdeps/mach/hurd/i386/libpthread.abilist 
>>> b/sysdeps/mach/hurd/i386/libpthread.abilist
>>> index fa90cc65..3ea7cb41 100644
>>> --- a/sysdeps/mach/hurd/i386/libpthread.abilist
>>> +++ b/sysdeps/mach/hurd/i386/libpthread.abilist
>>> @@ -164,3 +164,5 @@ GLIBC_2.32 tss_create F
>>>  GLIBC_2.32 tss_delete F
>>>  GLIBC_2.32 tss_get F
>>>  GLIBC_2.32 tss_set F
>>> +GLIBC_2.40 pthread_getname_np F
>>> +GLIBC_2.40 pthread_setname_np F
>>> diff --git a/sysdeps/mach/hurd/x86_64/libpthread.abilist 
>>> b/sysdeps/mach/hurd/x86_64/libpthread.abilist
>>> index 80615d16..69999df5 100644
>>> --- a/sysdeps/mach/hurd/x86_64/libpthread.abilist
>>> +++ b/sysdeps/mach/hurd/x86_64/libpthread.abilist
>>> @@ -163,3 +163,5 @@ GLIBC_2.38 tss_create F
>>>  GLIBC_2.38 tss_delete F
>>>  GLIBC_2.38 tss_get F
>>>  GLIBC_2.38 tss_set F
>>> +GLIBC_2.40 pthread_getname_np F
>>> +GLIBC_2.40 pthread_setname_np F
>>
>> I wonder if this can pass the hard freeze? It's arguably not a new
>> ABI: it's just an implementation of the expected ABI on the GNU/Hurd
>> platform.
> 
> Hi Samuel, 
> since this is only affecting hurd, I'd say it is your call. If you still want 
> to push it 
> then please do it soon though. Thanks!
> Andreas

Andreas is the release manager for 2.40 and if he has approved this then you 
can push.

There isn't a global ABI impact because other OSs and targets already have this 
symbol.

Please feel free to move forward, but please do so as soon as possible.

-- 
Cheers,
Carlos.