[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach, hur
From: |
Sergey Bugaev |
Subject: |
Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach, hurd}user |
Date: |
Sun, 19 Mar 2023 18:39:20 +0300 |
On Sun, Mar 19, 2023 at 6:19 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>
> Hello,
>
> Thanks for this work! :D
Yay! Can you believe just how glad I am to finally have completed it :D
> I don't have the time now to review the whole series, just a comment
> here: we don't really want to introduce abilist for lib{mach,hurd}user
> since their content will depend on the mach/hurd version glibc gets
> built against.
But isn't accidental ABI breakage (or unintended ABI additions)
exactly what the abilist mechanism is designed to guard against? It
doesn't even break your build (unlike -Werror) -- it's more of a lint.
You *would* want to know if your libhurduser.so build suddenly doesn't
include, say, proc_pid2task, because user code links to
lib{mach,hurd}user (via the libc.so linker script) and uses those
symbols, and would break if the symbols were to disappear.
No?
Well in any case, the abilists aren't essential. Freel free to drop
this commit (and remove lib{mach,hurd}user.abilist from the next one)
if that was the wrong call.
Sergey
- [RFC PATCH glibc 29/34] hurd: Add vm_param.h for x86_64, (continued)
- [RFC PATCH glibc 29/34] hurd: Add vm_param.h for x86_64, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 31/34] hurd: Microoptimize _hurd_self_sigstate (), Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 26/34] hurd: Remove __hurd_local_reply_port, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 20/34] htl: Add tcb-offsets.sym for x86_64, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 27/34] hurd: Don't leak __hurd_reply_port0, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 28/34] hurd: Implement _hurd_longjmp_thread_state for x86_64, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 30/34] hurd: Implement longjmp for x86_64, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 32/34] hurd: Implement sigreturn for x86_64, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach, hurd}user, Sergey Bugaev, 2023/03/19
- [RFC PATCH glibc 34/34] hurd: Add expected abilist files for x86_64, Sergey Bugaev, 2023/03/19
Re: [RFC PATCH 00/34] The rest of the x86_64-gnu port, Luca, 2023/03/19