Re: [PATCH 4/4] lwip: Call if_change_flags() inside a thread-safe context

[Samuel Thibault]

Joan Lledó, le ven. 03 mai 2019 13:37:59 +0200, a ecrit:
> Missatge de Samuel Thibault <samuel.thibault@gnu.org> del dia dv., 3
> de maig 2019 a les 0:02:
> > In C, there is no need to explicit the cast from void*.
> 
> I'm doing a similar cast on lwip-util.c:256. Should I remove it too?

Yes, there is no need to clutter the code with such trivial casts.

> > Errno is a per-thread variable, you can not propagate the error this
> > way. You can for instance add an int field to if_change_flags_args, to
> > read it from if_change_flags and freeing it there.
> 
> Totally true, I forgot it.
> 
> If I add an output parameter to *args, then I need to wait for the
> callback to finish before freeing *args. Because tcpip_callback()
> returns immediatelly.

You want to know whether the operation was completed successfully or
not, anyway.

Samuel