bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h


From: Justus Winter
Subject: Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h
Date: Thu, 31 Dec 2015 16:28:14 +0100
User-agent: alot/0.3.7.dev1

Quoting Samuel Thibault (2015-12-31 16:11:30)
> Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote:
> > This fixes three compiler warnings about ports_payload_get_name.
> > 
> > * devnode/Makefile: Define DEVICE_IMPORTS.
> > * term/Makefile: Likewise.
> > * trans/Makefile: Likewise.
> 
> Why not adding them to the corresponding mig-mutate.h?

Sometimes we don't have a mig-mutate.h, e.g. for most (all?)
translators in trans/.  I prefer stuffing that in a .h as well, but I
wouldn't be opposed to just applying the patch, as we use both ways of
mutating the mig types.

Justus

Attachment: signature.asc
Description: signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]