[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix compiler warnings in hurd/console-client
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH] fix compiler warnings in hurd/console-client |
|
Date: |
Tue, 29 Dec 2015 20:48:03 +0100 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Samuel Thibault, on Tue 29 Dec 2015 20:43:24 +0100, wrote:
> Flavio Cruz, on Tue 29 Dec 2015 17:35:00 +0100, wrote:
> > @@ -663,10 +663,11 @@ update_leds (void)
> > | (led_state.num_lock ? 2 : 0)
> > | (led_state.caps_lock ? 4 : 0);
> >
> > - err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2,
> > &data_cnt);
> > + err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2,
> > + (int *) &data_cnt);
> > if (!err && data_cnt == 1)
> > err = device_write_inband (kbd_dev, 0, -1, (void *) &leds[1], 1,
> > - &data_cnt);
> > + (int *) &data_cnt);
> > }
> > }
> >
>
> I'm surprised: if the device_write_inband RPC really wants an int*, why
> not making data_cnt an int?
(I have applied the rest)