Re: [PATCH 5/6] hurd_add_RPC

[Justus Winter]

Quoting Samuel Thibault (2015-03-05 02:14:38)
> Hello,
> 
> Svante Signell, le Thu 22 Jan 2015 10:29:56 +0100, a écrit :
> > +/* Do fcntl type locking on FILE. CMD is from the set
> > + F_GETLK64, F_SETLK64, F_SETLKW64. FLOCK64 is passed
> > + by the user and is as defined by <fcntl.h>. */
> > +routine file_record_lock (
> > +       file: file_t;
> > +       RPT
> > +       cmd: int;
> > +       inout flock64: flock_t);
> 
> I'm wondering whether we are OK with using the flock_t structure,
> instead of using separate parameters?  I don't really have an opinion on
> this, just wondering.

I'm ok with that.  We'll have to teach MIG proper structure support
one day anyway.

Justus

signature.asc
Description: signature